Skip to content

fix: preserve legacy model config key #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
buyua9 wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −1
Open

fix: preserve legacy model config key #174

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/helpers/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,10 @@ type ConfigKeys = keyof typeof configParsers;

type RawConfig = {
[key in ConfigKeys]?: string;
} & {
// Backwards compatibility for config files written before MODEL was
// promoted to the canonical uppercase key.
model?: string;
};

type ValidConfig = {
Expand Down Expand Up @@ -92,7 +96,10 @@ export const getConfig = async (

for (const key of Object.keys(configParsers) as ConfigKeys[]) {
const parser = configParsers[key];
const value = cliConfig?.[key] ?? config[key];
const value =
key === 'MODEL'
? cliConfig?.MODEL ?? cliConfig?.model ?? config.MODEL ?? config.model
: cliConfig?.[key] ?? config[key];
parsedConfig[key] = parser(value);
}

Expand All @@ -109,6 +116,10 @@ export const setConfigs = async (keyValues: [key: string, value: string][]) => {

const parsed = configParsers[key as ConfigKeys](value);
config[key as ConfigKeys] = parsed as any;

if (key === 'MODEL') {
delete config.model;
}
}

await fs.writeFile(configPath, ini.stringify(config), 'utf8');
Expand Down