Add space management UI: rename and delete - #2626
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Here's a visual recap of what changed: Open the full interactive recap |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Builder reviewed your changes — looks good ✅
Review Details
Incremental Code Review Summary
The latest commit fixes all previously reported actionable issues: card context-menu items now use Radix onSelect and defer opening dialogs, sidebar labels use the new localization keys, and rename/delete AlertDialog actions prevent the default close until their mutations complete. The earlier active-space navigation and admin-only gating fixes remain present.
Review risk remains High because this feature exposes destructive space deletion. No new runtime or security defects were found by the parallel review agents. Two low-severity maintainability observations remain: the sidebar still passes an unused empty renameSpaceName prop, and SpaceCardProps.onMutationSuccess declares a no-argument callback even though the shared dialog may forward a deleted-space ID. Neither is currently user-visible or actionable at the merge-blocking threshold.
The implementation otherwise has consistent action authorization, mutation pending-state guards, localized card/dialog strings, successful refetch behavior, and active-route recovery after deletion.
🧪 Browser testing: Will run after this review (PR touches UI code)

Users can now rename and delete spaces directly from the UI. The sidebar and space cards show context menus with these actions, replacing the need to use the CLI or agent.
Changes
Space Management Features
Code Organization
SpaceDialogscomponent used by both the sidebar and space cards