Skip to content

Add space management UI: rename and delete - #2626

Merged
shomix merged 7 commits into
mainfrom
shomix-p-space-delete-ui
Aug 5, 2026
Merged

Add space management UI: rename and delete#2626
shomix merged 7 commits into
mainfrom
shomix-p-space-delete-ui

Conversation

@shomix

@shomix shomix commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Users can now rename and delete spaces directly from the UI. The sidebar and space cards show context menus with these actions, replacing the need to use the CLI or agent.

Changes

Space Management Features

  • Right-click on space cards in the spaces list to access a context menu with rename and delete options
  • Three-dot menu appears on hover for spaces in the sidebar, with the same rename and delete actions
  • Rename dialog lets users change the space name with a simple input field
  • Delete dialog confirms the action and warns that it removes the space from all recordings
  • Both actions only appear to users with admin permissions

Code Organization

  • Extracted shared rename and delete dialogs into a new SpaceDialogs component used by both the sidebar and space cards
  • This removes about 100 lines of duplicated dialog code and makes maintenance easier
  • Both components now share the same mutation logic and UI
image image image

@netlify

This comment has been minimized.

@netlify

This comment has been minimized.

@netlify

This comment has been minimized.

@netlify

This comment has been minimized.

@netlify

This comment has been minimized.

@netlify

This comment has been minimized.

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Here's a visual recap of what changed:

Visual recap

Open the full interactive recap

@netlify

This comment has been minimized.

@netlify

This comment has been minimized.

@netlify

This comment has been minimized.

@netlify

This comment has been minimized.

@netlify

This comment has been minimized.

@netlify

This comment has been minimized.

builder-io-integration[bot]

This comment was marked as outdated.

builder-io-integration[bot]

This comment was marked as outdated.

Milos Petrovic added 2 commits August 5, 2026 11:20
builder-io-integration[bot]

This comment was marked as outdated.

builder-io-integration[bot]

This comment was marked as outdated.

@builder-io-integration builder-io-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builder reviewed your changes — looks good ✅

Review Details

Incremental Code Review Summary

The latest commit fixes all previously reported actionable issues: card context-menu items now use Radix onSelect and defer opening dialogs, sidebar labels use the new localization keys, and rename/delete AlertDialog actions prevent the default close until their mutations complete. The earlier active-space navigation and admin-only gating fixes remain present.

Review risk remains High because this feature exposes destructive space deletion. No new runtime or security defects were found by the parallel review agents. Two low-severity maintainability observations remain: the sidebar still passes an unused empty renameSpaceName prop, and SpaceCardProps.onMutationSuccess declares a no-argument callback even though the shared dialog may forward a deleted-space ID. Neither is currently user-visible or actionable at the merge-blocking threshold.

The implementation otherwise has consistent action authorization, mutation pending-state guards, localized card/dialog strings, successful refetch behavior, and active-route recovery after deletion.

🧪 Browser testing: Will run after this review (PR touches UI code)

@shomix
shomix merged commit 56e69bb into main Aug 5, 2026
92 of 94 checks passed
@shomix
shomix deleted the shomix-p-space-delete-ui branch August 5, 2026 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants