fix(tests): repair quantum integration test for allowed job names#460
Merged
Conversation
The run_autorun_job whitelist rejects arbitrary names like 'another'; update the list/dict status-shape test to use 'smoke' so it exercises _find_job_status through the public API. Co-authored-by: Bryan
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the quantum integration test to use an allowed autorun job name ('smoke') instead of a disallowed value, keeping coverage of list/dict job status payload handling and the run_autorun_job contract intact. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
🟡 Coverage —
|
| Metric | Value |
|---|---|
| Total coverage | 65.2% |
→ vs main |
0.0% |
| Minimum threshold | 60% |
Updated on every push · 2026-06-20
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hourly repo health automation failed on two quantum integration tests. The tests called
run_autorun_job("another"), but the API only accepts whitelisted job names (baseline,benchmark,nightly,smoke).Changes
tests/test_quantum_integration.pyto use the allowedsmokejob name in both list- and dict-shaped status payload cases_find_job_statusnormalization through the publicrun_autorun_jobAPIVerification
pytest tests/test_quantum_integration.py— 2 passedCo-authored-by: Bryan
Summary by Sourcery
Tests:
Note
Low Risk
Test-only rename with no production code changes.
Overview
Repairs failing quantum integration tests by aligning fixture job names with
run_autorun_job’s allowed set (baseline,benchmark,nightly,smoke).Parameterized list- and dict-shaped
status.jsonpayloads and assertions now usesmokeinstead ofanother, so the tests still exercise status lookup without tripping the invalid job name guard.Reviewed by Cursor Bugbot for commit 7a73b1c. Bugbot is set up for automated code reviews on this repo. Configure here.