Fix Bifrost same-owner reference benchmark regressions#75
Merged
Conversation
DavidBakerEffendi
marked this pull request as ready for review
July 24, 2026 12:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix the UsageBench/Bifrost contract mismatch introduced when Bifrost began excluding same-owner receiver usages from its default external-usage surface.
UsageBench measures an LSP-shaped reference surface, so the adapter must explicitly request and normalize those references. This restores the eight Go, PHP, Python, and Ruby benchmark cases that regressed when scheduled runs picked up the newer Bifrost
master.Key Changes:
include_same_owner: truefromscan_usages_by_location.same_owner_filesas proven reference locations for both current and legacy response shapes.Validation:
cargo fmt --checkcargo test— 108 tests passedcargo run -- validate benchmarks/cases— 35 documents validatedda37db3— restored all eight regressed cases, returning to 133 passed / 16 pre-existing failures011ee62— passedTouch Points:
src/runners/bifrost.rsdocs/runner-adapters.md