Skip to content

Fix Bifrost same-owner reference benchmark regressions#75

Merged
DavidBakerEffendi merged 1 commit into
mainfrom
dave/include-same-owner-references
Jul 24, 2026
Merged

Fix Bifrost same-owner reference benchmark regressions#75
DavidBakerEffendi merged 1 commit into
mainfrom
dave/include-same-owner-references

Conversation

@DavidBakerEffendi

Copy link
Copy Markdown
Collaborator

Description

Fix the UsageBench/Bifrost contract mismatch introduced when Bifrost began excluding same-owner receiver usages from its default external-usage surface.

UsageBench measures an LSP-shaped reference surface, so the adapter must explicitly request and normalize those references. This restores the eight Go, PHP, Python, and Ruby benchmark cases that regressed when scheduled runs picked up the newer Bifrost master.

Key Changes:

  • Request include_same_owner: true from scan_usages_by_location.
  • Normalize same_owner_files as proven reference locations for both current and legacy response shapes.
  • Add focused request and parser coverage, and document the adapter contract.

Validation:

  • cargo fmt --check
  • cargo test — 108 tests passed
  • cargo run -- validate benchmarks/cases — 35 documents validated
  • Full benchmark against Bifrost da37db3 — restored all eight regressed cases, returning to 133 passed / 16 pre-existing failures
  • Compatibility probe against prior Bifrost 011ee62 — passed

Touch Points:

  • src/runners/bifrost.rs
  • docs/runner-adapters.md

@DavidBakerEffendi
DavidBakerEffendi marked this pull request as ready for review July 24, 2026 12:44
@DavidBakerEffendi
DavidBakerEffendi merged commit d01a4aa into main Jul 24, 2026
3 checks passed
@DavidBakerEffendi
DavidBakerEffendi deleted the dave/include-same-owner-references branch July 24, 2026 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant