Fix duplicate search bar in empty slot and back button top padding#324
Merged
Conversation
- Hide nested AvailableModulesMenu search input when CategoryMenu is in search mode (prevents duplicate search bar in empty slot). - Wrap search results in same .select.category-menu container so layout does not shift when typing. - Constrain nested .select inside .category-menu to static layout. - Add top padding to .select when .back-button child is present. - Track seen announcements per-id (seenAnnouncementIds JSON array in localStorage) instead of a single lastSeenAnnouncementId threshold. Infrequent visitors see unread entries individually. - Banner only shows for the newest announcement if unseen. - Bell pulse stops after 10s regardless of state. - Changelog page marks all announcements as seen. - Modal entries on changelog page force-close the modal on click. - Seen entries render in grey, unread in orange, newest in red-orange.
Michael-K-Williams
force-pushed
the
fix/module_search_issues
branch
from
989b01b to
4bde9e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two visual bugs introduced with the recent module search auto-focus work:
hideSearchprop and CategoryMenu passes it when in search mode.<div>instead of the.select.category-menucontainer, so the dropdown shrank when typing. The search branch now uses the same outer container, and a new rule constrains the nested.selectto static layout inside.category-menuso it does not take over the outer layout..select:has(.back-button)rule so the container has top padding when the back button is present.