Fix imported ships missing Advanced Planetary Approach Suite#317
Merged
Conversation
When importing from EDSY or other tools that don't include the Planetary Approach Suite in their export data, the PAS slot was left empty. Now defaults to Advanced Planetary Approach Suite (Odyssey) when the slot is not present in import data. Fixed in both import paths: - Journal/EDSY import (JournalUtils.js) - Companion API import (CompanionApiUtils.js)
alex-williams
force-pushed
the
fix/import_missing_apas
branch
from
6549739 to
0857a02
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When importing ships from EDSY or other third-party tools, the Advanced Planetary Approach Suite (Odyssey) was not being added to the ship. This is because these tools don't include the PAS in their export data since it's a mandatory fixed module.
Changes
Testing