Version refactor fix#321
Merged
Merged
Conversation
Switching to temp files introduced a regression where the tempfile was dropped in a replacement on the temp path, causing the temp path to be dropped prematurely.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // Use reqwest for the API call | ||
| debug!(" > Querying..."); | ||
| let mut url: String = info.api.to_string(); | ||
| let mut url: String = format!("http://{}", info.api); |
Check warning
Code scanning / devskim
An HTTP-based URL without TLS was detected. Warning
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Brane api responds with a version prefixed by a v. semver does not parse this v, so we have to strip it.
Think the problem is that the history feature was missing and rustyline, for some obscene reason, decided to add stubs instead of missing functions. Or it's that it works after two tries. Hard to say.
DanielVoogsgerd
force-pushed
the
version-refactor-fix
branch
from
62b5775 to
6975f88
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add various fixes for the version refactor PR