Skip to content

perf: drain response body before close on the success path#276

Merged
BoxBoxJason merged 1 commit into
mainfrom
fix/drain-body-on-success
Jun 13, 2026
Merged

perf: drain response body before close on the success path#276
BoxBoxJason merged 1 commit into
mainfrom
fix/drain-body-on-success

Conversation

@BoxBoxJason

Copy link
Copy Markdown
Owner

Description of your changes

This PR optimizes the behaviour of requests on success by adding the same drain mechanism the roundTripper has.
This allows to reuse the connection slot.

Closes #253

I have:

  • Followed the git conventional commit message format.
  • Made sure all changes are covered by proper tests, reaching a coverage of at least 80% when applicable.

How has this code been tested

I have:

  • Made sure make lint passes to verify that the code style is correct.
  • Made sure make test passes to verify that the code is working as intended.
  • Made sure make e2e passes to verify that end-to-end tests pass against a real SonarQube instance.
  • Added unit tests to cover the code changes.
  • Added end-to-end tests if necessary.

Signed-off-by: BoxBoxJason <contact@boxboxjason.dev>
@BoxBoxJason BoxBoxJason added this to the User Production Readiness milestone Jun 13, 2026
@BoxBoxJason BoxBoxJason self-assigned this Jun 13, 2026
@BoxBoxJason BoxBoxJason added enhancement New feature or request unit-test Unit test related work sdk SonarQube golang SDK related work labels Jun 13, 2026
@BoxBoxJason BoxBoxJason merged commit 5a53104 into main Jun 13, 2026
4 checks passed
@BoxBoxJason BoxBoxJason deleted the fix/drain-body-on-success branch June 13, 2026 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request sdk SonarQube golang SDK related work unit-test Unit test related work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Response body not drained on the successful JSON path

1 participant