Skip to content

feat: add configurable & default http timeout#274

Merged
BoxBoxJason merged 2 commits into
mainfrom
feat/default-http-timeout
Jun 13, 2026
Merged

feat: add configurable & default http timeout#274
BoxBoxJason merged 2 commits into
mainfrom
feat/default-http-timeout

Conversation

@BoxBoxJason

Copy link
Copy Markdown
Owner

Description of your changes

This PR adds a default timeout behaviour of 30 seconds on all requests.
This timeout is configurable using either the WithTimeout function or the ClientCreateOption: Timeout

Adds corresponding unit tests.

Closes #242

I have:

  • Followed the git conventional commit message format.
  • Made sure all changes are covered by proper tests, reaching a coverage of at least 80% when applicable.

How has this code been tested

I have:

  • Made sure make lint passes to verify that the code style is correct.
  • Made sure make test passes to verify that the code is working as intended.
  • Made sure make e2e passes to verify that end-to-end tests pass against a real SonarQube instance.
  • Added unit tests to cover the code changes.
  • Added end-to-end tests if necessary.

Signed-off-by: BoxBoxJason <contact@boxboxjason.dev>
Signed-off-by: BoxBoxJason <contact@boxboxjason.dev>
@BoxBoxJason BoxBoxJason added this to the User Production Readiness milestone Jun 13, 2026
@BoxBoxJason BoxBoxJason self-assigned this Jun 13, 2026
@BoxBoxJason BoxBoxJason added enhancement New feature or request unit-test Unit test related work sdk SonarQube golang SDK related work labels Jun 13, 2026
@BoxBoxJason BoxBoxJason changed the title Feat/default http timeout feat: add configurable & default http timeout Jun 13, 2026
@BoxBoxJason BoxBoxJason merged commit 0becd61 into main Jun 13, 2026
4 checks passed
@BoxBoxJason BoxBoxJason deleted the feat/default-http-timeout branch June 13, 2026 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request sdk SonarQube golang SDK related work unit-test Unit test related work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Default HTTP client has no timeout

1 participant