fix: only auto-retry idempotent methods by default#273
Merged
Conversation
Signed-off-by: BoxBoxJason <contact@boxboxjason.dev>
Signed-off-by: BoxBoxJason <contact@boxboxjason.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR corrects a potential bug that could appear when auto retry was configured, causing potential unknown effects on server side errors on non idempotent HTTP methods. This supposes that the SonarQube API abides by the HTTP conventions.
The client can be configured to retry on all methods.
Fixes #243
I have:
How has this code been tested
I have:
make lintpasses to verify that the code style is correct.make testpasses to verify that the code is working as intended.make e2epasses to verify that end-to-end tests pass against a real SonarQube instance.