Skip to content

fix: only auto-retry idempotent methods by default#273

Merged
BoxBoxJason merged 2 commits into
mainfrom
fix/only-retry-idempotent
Jun 13, 2026
Merged

fix: only auto-retry idempotent methods by default#273
BoxBoxJason merged 2 commits into
mainfrom
fix/only-retry-idempotent

Conversation

@BoxBoxJason

@BoxBoxJason BoxBoxJason commented Jun 13, 2026

Copy link
Copy Markdown
Owner

Description of your changes

This PR corrects a potential bug that could appear when auto retry was configured, causing potential unknown effects on server side errors on non idempotent HTTP methods. This supposes that the SonarQube API abides by the HTTP conventions.

The client can be configured to retry on all methods.

Fixes #243

I have:

  • Followed the git conventional commit message format.
  • Made sure all changes are covered by proper tests, reaching a coverage of at least 80% when applicable.

How has this code been tested

I have:

  • Made sure make lint passes to verify that the code style is correct.
  • Made sure make test passes to verify that the code is working as intended.
  • Made sure make e2e passes to verify that end-to-end tests pass against a real SonarQube instance.
  • Added unit tests to cover the code changes.
  • Added end-to-end tests if necessary.

Signed-off-by: BoxBoxJason <contact@boxboxjason.dev>
@BoxBoxJason BoxBoxJason added this to the User Production Readiness milestone Jun 13, 2026
@BoxBoxJason BoxBoxJason self-assigned this Jun 13, 2026
@BoxBoxJason BoxBoxJason added enhancement New feature or request unit-test Unit test related work sdk SonarQube golang SDK related work labels Jun 13, 2026
Signed-off-by: BoxBoxJason <contact@boxboxjason.dev>
@BoxBoxJason BoxBoxJason merged commit 6b321c0 into main Jun 13, 2026
4 checks passed
@BoxBoxJason BoxBoxJason deleted the fix/only-retry-idempotent branch June 13, 2026 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request sdk SonarQube golang SDK related work unit-test Unit test related work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Retry replays non-idempotent POST requests

1 participant