Skip to content

feat(ServiecBus): implement IQueueMessageSender in ServiceBusTopicManager#150

Open
tobiasbalzano wants to merge 4 commits into
masterfrom
feat/service-bus-management-topic-sender
Open

feat(ServiecBus): implement IQueueMessageSender in ServiceBusTopicManager#150
tobiasbalzano wants to merge 4 commits into
masterfrom
feat/service-bus-management-topic-sender

Conversation

@tobiasbalzano
Copy link
Copy Markdown
Contributor

@tobiasbalzano tobiasbalzano commented Jun 10, 2025 •
edited
Loading

This will enable us to publish events via ServiceBusTopicManager and PostgresTopicManager

@aurora-codereview
Copy link
Copy Markdown

aurora-codereview Bot commented Jun 10, 2025 •
edited
Loading

[bb-code-review]

PR Review 🚀

  • The DI registrations now cleanly bind both IQueueManager and IQueueMessageSender for topics which simplifies consumer resolution. 👍

  • The implementation of SendMessage in both ServiceBusTopicManager and PostgresTopicManager is clear and straightforward. Nice use of the respective SDK methods! 📬

  • The extension of the PostgresManagementClient with PublishEvent and DeleteTopic methods works well to support topic publishing and cleanup. The SQL commands are well encapsulated.

  • Unit/integration tests have been updated to cover the new topic functionalities, which is great for verifying the changes. ✅

Overall, the changes are solid and directly implement the required features. Great work! 🎉

@tobiasbalzano tobiasbalzano force-pushed the feat/service-bus-management-topic-sender branch 2 times, most recently from 73c6a99 to 9ae798c Compare June 10, 2025 06:03
@tobiasbalzano tobiasbalzano changed the title feat(ServiecBus): implement IQueueMessageSender in ServiceBusTopicMan… feat(ServiecBus): implement IQueueMessageSender in ServiceBusTopicManager Jun 10, 2025
@tobiasbalzano tobiasbalzano marked this pull request as ready for review June 10, 2025 11:59
@tobiasbalzano tobiasbalzano force-pushed the feat/service-bus-management-topic-sender branch from 9ae798c to c21782c Compare June 10, 2025 12:36
@tobiasbalzano tobiasbalzano force-pushed the feat/service-bus-management-topic-sender branch 3 times, most recently from 4367ff1 to 704922b Compare June 11, 2025 10:14
elmaxe
elmaxe reviewed Jun 12, 2025
View reviewed changes
Comment thread knightbus-postgresql/tests/KnightBus.PostgreSql.Tests.Integration/PostgresBusTests.cs
Comment thread knightbus-postgresql/tests/KnightBus.PostgreSql.Tests.Integration/PostgresBusTests.cs Outdated
@tobiasbalzano tobiasbalzano force-pushed the feat/service-bus-management-topic-sender branch from 704922b to 6b48c90 Compare June 12, 2025 12:09
@tobiasbalzano tobiasbalzano requested a review from elmaxe June 12, 2025 12:09
@tobiasbalzano tobiasbalzano force-pushed the feat/service-bus-management-topic-sender branch from 6b48c90 to 92fb557 Compare June 12, 2025 12:10
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 12, 2025

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mbaneryd mbaneryd Awaiting requested review from mbaneryd

@NiklasArbin NiklasArbin Awaiting requested review from NiklasArbin

@elmaxe elmaxe Awaiting requested review from elmaxe

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tobiasbalzano @elmaxe