Skip to content

Add drawer body font size setting and update defaults#13

Merged
BobDLA merged 3 commits into
mainfrom
feat/drawer-font-size-defaults
Mar 20, 2026
Merged

Add drawer body font size setting and update defaults#13
BobDLA merged 3 commits into
mainfrom
feat/drawer-font-size-defaults

Conversation

@BobDLA

@BobDLA BobDLA commented Mar 20, 2026

Copy link
Copy Markdown
Owner

Summary

  • add a persisted body font size slider to the drawer settings and apply it to post body and code blocks
  • change the default drawer options to iframe preview, full topic, 15px body text, all authors, default order, floating reply off, overlay mode, and narrow width
  • update smoke coverage and docs so preview-mode-sensitive cases set up their own scenario explicitly
  • ignore the local temp directory in .gitignore

Verification

  • bash scripts/check.sh
  • bash scripts/agent-smoke.sh --cdp-port 9222 --cases AGENT-CHROME-001,AGENT-CHROME-002,AGENT-CHROME-003,AGENT-CHROME-004,AGENT-CHROME-005,AGENT-CHROME-006,AGENT-CHROME-008,AGENT-CHROME-009,AGENT-CHROME-010,AGENT-CHROME-016

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8ff748c513

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/content.js Outdated
Comment on lines +213 to +217
<label class="ld-setting-field">
<div class="ld-setting-row">
<span class="ld-setting-label">正文字号</span>
<span class="ld-setting-value" data-setting-value="postBodyFontSize">15px</span>
</div>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Hide or disable the body font-size slider in iframe mode

This new control is shown unconditionally, but on a fresh install previewMode now defaults to "iframe" in DEFAULT_SETTINGS, and the slider only feeds the --ld-post-body-font-size CSS variable that is consumed by .ld-post-body in smart preview. In the default configuration there is no .ld-post-body at all—loadTopic() renders an <iframe> instead—so the new setting appears broken until the user discovers they must switch preview modes first.

Useful? React with 👍 / 👎.

Comment thread src/content.js
@BobDLA BobDLA merged commit 839ef58 into main Mar 20, 2026
1 check passed
@BobDLA BobDLA assigned BobDLA and unassigned BobDLA Mar 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant