Skip to content

fix: address pending PR review follow-ups#11

Merged
BobDLA merged 2 commits into
mainfrom
chore/pr-review-followups-clean
Mar 20, 2026
Merged

fix: address pending PR review follow-ups#11
BobDLA merged 2 commits into
mainfrom
chore/pr-review-followups-clean

Conversation

@BobDLA

@BobDLA BobDLA commented Mar 20, 2026

Copy link
Copy Markdown
Owner

Summary

  • add Firefox data_collection_permissions.required = ["none"] and enforce it in release artifact checks
  • harden AGENT-CHROME-010 by skipping targeted topic links and waiting for refresh completion instead of sleeping a fixed interval
  • extend drawer scroll containment and Firefox scrollbar styling to inner scrollable containers
  • sync AGENTS/testing docs with the stronger Firefox artifact check

Why

This PR addresses still-valid automated review feedback left on earlier PRs:

Validation

Tier 0

  • bash scripts/check.sh
  • bash -n scripts/agent-smoke.sh

Tier 1

  • bash scripts/build-release-artifacts.sh v0.0.0-local /tmp/linux-do-sidepeek-dist-pr-review
  • bash scripts/check-release-artifacts.sh /tmp/linux-do-sidepeek-dist-pr-review/linux-do-sidepeek-0.0.0-local-chrome.zip /tmp/linux-do-sidepeek-dist-pr-review/linux-do-sidepeek-0.0.0-local-firefox-unsigned.xpi

Tier 2

  • not run: current live Chrome session was loading a different unpacked worktree, so the result would not have been trustworthy

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 86b3e54f6d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/agent-smoke.sh Outdated
Comment thread src/content.css Outdated
@BobDLA BobDLA merged commit cee90c2 into main Mar 20, 2026
1 check passed
@BobDLA BobDLA deleted the chore/pr-review-followups-clean branch March 20, 2026 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant