fix(BezelNotification): handle non-RGB colorspace for background tint alpha#35
Open
Jah-yee wants to merge 1 commit into
Open
fix(BezelNotification): handle non-RGB colorspace for background tint alpha#35Jah-yee wants to merge 1 commit into
Jah-yee wants to merge 1 commit into
Conversation
… alpha When rawBackgroundTint is not in an RGB colorspace, getRed() returns false and the alpha parameter is left unmodified (zero), making the tint fully-transparent. Use alphaComponent as a fallback for non-RGB colorspaces so that tint works correctly regardless of the source color's colorspace. Fixes BlueHuskyStudios#28
Contributor
Author
|
Thank you for this detailed bug report! The fix adds a fallback to use Changes:
This is a minimal, surgical fix that only changes the alpha-extraction logic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When rawBackgroundTint is not in an RGB colorspace, getRed() returns false and the alpha parameter is left unmodified (zero), making the tint fully-transparent. Use alphaComponent as a fallback for non-RGB colorspaces so that tint works correctly regardless of the source color's colorspace.
Fixes #28