Skip to content

Promote stage -> main (XAML 2-space #22 + Android keyboard fix)#53

Merged
ChrisPelatari merged 3 commits into
mainfrom
stage
Jun 6, 2026
Merged

Promote stage -> main (XAML 2-space #22 + Android keyboard fix)#53
ChrisPelatari merged 3 commits into
mainfrom
stage

Conversation

@ChrisPelatari

Copy link
Copy Markdown
Member

Promotes stage → main (production) via a merge commit — per the branch model (no squash, no back-merge). Gated on Build + Test.

Ships to production this cycle:

  • Are four space tabs required for XAML code? #22 — all 12 XAML files reindented 4-space → 2-space (provably whitespace-only via git diff -w), plus .editorconfig / .vscode/settings.json / .vscode/extensions.json / .gitignore locking the 2-space convention for VSCodium. Verified four independent ways (deterministic gate, XML well-formedness, adversarial per-file review, CI build + 176 tests).
  • Android editor keyboard-hiding fix (df26d62) — EditorPage.xaml.cs, EditorViewModel.cs, MainActivity.cs, Resources/Raw/editor/index.html.

Closes #22

🤖 Generated with Claude Code

ChrisPelatari and others added 3 commits June 6, 2026 10:56
)

XAML has no required indent width; 4-space was just convention. Reindent all
12 XAML files from 4-space to 2-space:
  - structural nesting indent halved (N*4 -> N*2)
  - column-aligned multi-line attributes and comments re-aligned to the first
    attribute / comment text under the new (halved) structural indent
  - hanging-indent attribute lists (element name alone on its line) halved
Pure whitespace change: 879 insertions / 879 deletions across the 12 files,
every changed line a 1:1 leading-whitespace replacement (no content moved).

Lock the convention so it stays 2-space:
  - .editorconfig: [*.{xaml}] indent_size 4 -> 2
  - .vscode/settings.json: force 2-space for XML/XAML, detectIndentation off
  - .vscode/extensions.json: recommend EditorConfig so .editorconfig is honored
  - .gitignore: whitelist the two shared .vscode files (the dir was ignored)

Verified four independent ways: a deterministic only-leading-whitespace gate
(12/12), XML well-formedness (12/12), an independent adversarial per-file review
(12/12, zero defects), and a CI-parity build where XamlC compiles every XAML
(0 warn / 0 err) plus xUnit (176 passed).

Closes #22

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Promote develop -> stage (XAML 2-space #22 + Android keyboard fix)
@ChrisPelatari ChrisPelatari merged commit b0e68ee into main Jun 6, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Are four space tabs required for XAML code?

1 participant