DRAFT PR by CJLucido · Pull Request #145 · BloomTech-Labs/trashpanda-fe

changed max-width of 575 to 700, and 573 to 697, etc on BottomNav, CameraNav and App

CJLucido

committed

trying different api

CJLucido

committed

checking window. screen on mobile device

CJLucido

committed

window.screen.orientation.type

CJLucido

committed

locked screen on tutorial 'next' click

CJLucido

committed

added screen lock to App file but commented out so that tutorial page doesn't jump during locking phase, attached screen lock to home page because this is the first plact that we need it

CJLucido

committed

the useEffect on App wasn't commented out

CJLucido

committed

useEffect was not defined on home page

CJLucido

committed

trying load event

CJLucido

committed

change to fullscreen and lock on last tutorial next button or any click on the category page

CJLucido

committed

trying without fullscreen request

CJLucido

committed

requires fullscreen request, commented out screen lock and fullscreen on last next button of tutorial because it was making a race condition and sometimes reloading the tutorial (the sideeffect and…

CJLucido

committed

it wasn't causing a race condition, something else is restarting the tutorial on homepage load

CJLucido

committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

DRAFT PR#145

DRAFT PR#145
CJLucido wants to merge 18 commits into
masterfrom
Feature/108

Commits on Feb 25, 2020

added screen lock useEffect to App component, need to push as draft for netlify link to test on mobile

changed placeholder img on cluster page from svg to png for netlify deployment

requestFullscreen not requestFullScreen

attempt to use Ref

removed document methods, only using screen

Commits on Feb 26, 2020

changed max-width of 575 to 700, and 573 to 697, etc on BottomNav, CameraNav and App

trying different api

checking window. screen on mobile device

window.screen.orientation.type

locked screen on tutorial 'next' click

added screen lock to App file but commented out so that tutorial page doesn't jump during locking phase, attached screen lock to home page because this is the first plact that we need it

the useEffect on App wasn't commented out

useEffect was not defined on home page

trying load event

change to fullscreen and lock on last tutorial next button or any click on the category page

trying without fullscreen request

requires fullscreen request, commented out screen lock and fullscreen on last next button of tutorial because it was making a race condition and sometimes reloading the tutorial (the sideeffect and…

it wasn't causing a race condition, something else is restarting the tutorial on homepage load