TAA: motion-aware disocclusion edge (sparkle slice 1); unjittered-current is slice 2 - #113
Merged
Conversation
…e rest-sparkle The temporal-variance rig (shooter tools/f12-live.ps1 + high-pass stddev over 5 live captures) showed TAA ADDING flicker on static detailed surfaces vs TAA-off (bank 3.99 vs 1.94, grass 3.46 vs 1.03). Two mechanisms found: 1. FIXED HERE: the disocclusion reject's 0.25-sigma lower edge - at rest, sub-pixel jitter walks pebble/grass detail across it every few frames, oscillating alpha between converged history and raw frame. Rest pixels now need 0.6 sigma (motion keeps 0.25; the chroma-poison flush still fires at ~1 sigma). Measured: bank 3.99 -> 3.83, grass 3.46 -> 3.27. Real, small. 2. THE DOMINANT TERM, identified and left for its own change: sample_catmull_rom(in.uv) samples the CURRENT frame at its jittered position - the resolve never unjitters, so alpha x jitter-difference shimmers into every output frame by construction (~0.1 x edge contrast at rest). Fix = pass the frame's jitter through TaaParams (padding fields free) and offset the current sample - with care at rs < 1 where TSR uses jitter as its super-resolution source.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe TAA shader’s disocclusion rejection threshold now uses motion to adjust its lower variance bound, while preserving the existing upper bound. ChangesTAA threshold adjustment
Estimated code review effort: 2 (Simple) | ~10 minutes ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First measured slice of the rest-sparkle fix. The disocclusion reject's tight 0.25σ lower edge oscillated alpha on jittered static detail — now 0.6σ at rest, 0.25σ under motion (its reason to exist), chroma-flush intact. Measured: bank 3.99→3.83, grass 3.46→3.27.
The dominant term is identified for slice 2: the resolve samples the current frame at its jittered position (no unjitter offset), so α×jitter-difference shimmers into every frame by construction. Needs jitter in
TaaParams+ care at rs<1 (TSR uses jitter for super-resolution). Rig + baselines in the shooter:tools/f12-live.ps1, archived capturestools/.testout/v2-*.png.Summary by CodeRabbit