Fix: Date Picker, Mobile Voting UI, NYC Token Decimals, and Hardware Wallet Suppor#7
Open
winsznx wants to merge 1 commit into
Open
Fix: Date Picker, Mobile Voting UI, NYC Token Decimals, and Hardware Wallet Suppor#7winsznx wants to merge 1 commit into
winsznx wants to merge 1 commit into
Conversation
|
@svectoranu is attempting to deploy a commit to the blocksurvey1's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
There is no test build publicly available, right? |
Author
|
alright, i will make that and update the repo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses four reported issues to improve the user experience and reliability of the Ballot application.
Changes:
Improved Voting Period UX (Issue #2)
Replaced manual Block Height inputs with datetime-local date pickers in the Poll Builder.
Added calculateBlockHeightFromDate utility to automatically estimate block heights based on selected dates.
Mobile UI Fixes (Issue #1)
Fixed responsive CSS in styles/Poll.module.css to ensuring the "Cast Your Vote" section is visible on mobile devices.
Scoped the hiding of .action_secondary_btn in styles/globals.css to the navigation bar only, preventing unintended hiding of buttons in other views.
Strategy Token Corrections (Issue #3)
Verified the existence of MIA and NYC voting strategies.
Corrected the strategyTokenDecimals for NewYorkCityCoin (NYC) from 0 to 6 in common/constants.js
Hardware Wallet Support (Issue #6)
Added anchorMode: AnchorMode.Any to the cast-my-vote contract call in services/contract.js
This resolves transaction failures often experienced when using Leather with Ledger devices.
Verification:
Date Picker: Verified that changing the date updates the estimated block height.
Mobile: Verified that the voting interface is now accessible on smaller screens.
Contracts: Verified that transactions now include the correct anchor mode.