Add CP424 to Charset enum (Hebrew support)

[roi0507]

Great project!
Started doing dm3270 cleanup, until I found this library.
Will include the library in https://community.openlegacy.com/ol-terminal - OpenLegacy free web based terminal

Roi Mor, CTO

[Baraujo25]

@roi0507 Thank you so much for your interest in the project, I truly appreciate your contribution even more!

[Baraujo25]

Thank you for the effort you've put into adding these tests! However, I noticed that the tests currently rely on a real service connection. While this can provide some insights, it introduces potential flakiness and variability in our test results, which we want to avoid.

Additionally, the real service uses actual credentials that are likely stored in a property file, which for security reasons, I assume you did not include in the PR. This means that anyone trying to run these tests without those credentials will encounter failures.

In our project, we typically mock the service by recording the original flow and obfuscating sensitive information. This approach not only helps maintain consistent test results but also ensures that our tests run reliably every time.

Could we consider refactoring these tests to align with our mocking strategy?
You can follow any guide here on how to generate a dump file or see this video that walkthrough the process step by step: https://www.youtube.com/watch?v=Sr1BOi50xqg&t=2163s

We use Wiresham as our server mock tool. Once you have the dump, it's possible to obfuscate any sensible information presented either in the screen or as inputs.

I'm happy to help with this process!

Thank you again for your contributions!

[roi0507]

Hi @Baraujo25, Thanks for the details review. I meant to commit it to our forked repo only. You can ignore it, if you wish to accept the pull request.
Welcome you to try ol-terminal which uses this library :)