Skip to content

Fix Intel RST BSOD Issue#8

Merged
Blacktempel merged 8 commits into
Blacktempel:masterfrom
a1ive:fix-intel-rst
Apr 15, 2026
Merged

Fix Intel RST BSOD Issue#8
Blacktempel merged 8 commits into
Blacktempel:masterfrom
a1ive:fix-intel-rst

Conversation

@a1ive
Copy link
Copy Markdown
Contributor

@a1ive a1ive commented Apr 13, 2026

This PR aims to fix the issue described in #7

Comment thread DiskInfoToolkit/Probes/IntelRaidMiniportProbe.cs Outdated
This prevents probing the wrong PHY when a specific SCSI target is requested.
@a1ive a1ive marked this pull request as ready for review April 14, 2026 10:51
Copilot AI review requested due to automatic review settings April 14, 2026 10:51
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses the BSOD reported in #7 by adjusting how devices behind Intel RST controllers are classified and probed, and by tightening device selection for RAID/CSMI probing paths.

Changes:

  • Update Intel RAID miniport NVMe pass-through request fields used with IOCTL_SCSI_MINIPORT.
  • Refine CSMI PHY selection to match the device’s SCSI TargetID when available.
  • Adjust probe strategy selection and NVMe probe ordering to better handle Intel RST hybrid controllers.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
DiskInfoToolkit/Probes/IntelRaidMiniportProbe.cs Sets Intel miniport request fields for NVMe pass-through via SCSI miniport.
DiskInfoToolkit/Probes/CsmiProbe.cs Filters PHY selection by TargetID to avoid probing the wrong port/device.
DiskInfoToolkit/Core/StorageProbeDispatcher.cs Reorders NVMe probing attempts (Intel/VROC/miniport before standard NVMe query).
DiskInfoToolkit/Core/StorageDetectionEngine.cs Adds Intel RST hybrid-controller strategy selection to route SATA devices to RAID probing.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread DiskInfoToolkit/Core/StorageDetectionEngine.cs Outdated
@Blacktempel
Copy link
Copy Markdown
Owner

Blacktempel commented Apr 14, 2026

private static void SelectProbeStrategy(StorageDevice device)

I have pushed an update for that method to master.
The changes in this PR may work for this case, but I don't think that was enough.

Please merge / rebase this into your branch and test with these changes (keep remote changes).
That should work for your case too & more other cases too.
I've already checked for my VROC, RST and other disks. Still works fine.

Edit: if that works for you aswell, the changes in StorageProbeDispatcher can be reverted too.

Comment thread DiskInfoToolkit/Probes/IntelRaidMiniportProbe.cs
@Blacktempel
Copy link
Copy Markdown
Owner

Are the changes working for you aswell ?

@a1ive
Copy link
Copy Markdown
Contributor Author

a1ive commented Apr 15, 2026

Are the changes working for you aswell ?

Yes.

@Blacktempel Blacktempel merged commit 86fde6c into Blacktempel:master Apr 15, 2026
@a1ive a1ive deleted the fix-intel-rst branch April 16, 2026 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants