fix(extension): move ask_user registration to runtime to avoid conflicts#4
Open
hdkiller wants to merge 2 commits into
Open
fix(extension): move ask_user registration to runtime to avoid conflicts#4hdkiller wants to merge 2 commits into
hdkiller wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the registration of the
ask_usertool from extension activation time tosession_start.This resolves a static naming conflict with the global
pi-ask-userextension and other extensions (like the dashboard bridge) that might also want to provide anask_usertool.By registering at runtime, we allow the CLI to load multiple extensions that offer the same tool name, with the last one registered during session start becoming the active one for that session. This matches the pattern already used in the
pi-agent-dashboardbridge.