feat: accept certificate name on fellowship application (write-through to user.name)#85
Merged
Merged
Conversation
…h to user.name
Add an optional `name` field to the fellowship application proposal body
(POST /fellowship-applications and PATCH /fellowship-applications/{id}).
It is the applicant's name used on the certificate and is written through
to `user.name` rather than stored on the application, mirroring how
`location` behaves: trimmed, empty-string clears, omitted leaves untouched.
The value is served back via the existing `name` field on GET /users/me
(used by the form to prefill), so no new column, migration, or DTO field
is required.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
theanmolsharma
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the applicant's certificate name to the fellowship application flow, wired the same way
locationalready works — submitted in the proposal payload and written through to the user profile rather than stored on the application.Per review, the certificate name reuses the existing
user.nameprofile field, so no new column, migration, or DTO field is introduced.Changes
fellowship-applications.request.dto.ts— add optionalnametoProposalFieldsDto(accepted onPOST /fellowship-applicationsandPATCH /fellowship-applications/{id}), mirroringlocation:@IsOptional @Transform(trim) @IsString @MaxLength(255).fellowship-applications.service.ts— inapplyProfileFields, writenamethrough touser.nameviaemptyToNull: trimmed, empty-string clears, omitted key leaves it untouched. Not stored on the application.Behavior (matches
location)user.name; not stored on the applicationGET /users/menamefield (used for prefill)Frontend follow-up
The frontend must send/read
name(notcertificateName) in the proposal body and prefill fromGET /users/me->name.Testing
tsc --noEmitpasses.🤖 Generated with Claude Code