fix: add blind-sign gate to TRON TIP-712 typed hash signing#244
Open
BitHighlander wants to merge 2 commits into
Open
fix: add blind-sign gate to TRON TIP-712 typed hash signing#244BitHighlander wants to merge 2 commits into
BitHighlander wants to merge 2 commits into
Conversation
TIP-712 signing sends only pre-computed hashes — the device cannot reconstruct or verify the original typed-data struct. Typed-data signatures can authorise token approvals and permits. Add an explicit acknowledgement screen before showing the raw hashes so users understand they are signing unverifiable data.
deps/device-protocol → 8ef74da (feat(ripple): memo + THORChain routing) deps/python-keepkey → bf870e6 (7.14.2: XRP memo + EVM depositWithExpiry + msg-signing)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fsm_msgTronSignTypedHashreceived pre-computed domain separator and message hashes from the host and signed them without warning the user that the device cannot verify the typed-data contents.Files Changed
lib/firmware/fsm_msg_tron.h— add blind-sign confirmation gate infsm_msgTronSignTypedHashbefore processing hashesTest Plan
ActionCancelled)