fix: widen TokenType.chain_id from uint8_t to uint32_t#240
Open
BitHighlander wants to merge 2 commits into
Open
fix: widen TokenType.chain_id from uint8_t to uint32_t#240BitHighlander wants to merge 2 commits into
BitHighlander wants to merge 2 commits into
Conversation
chain_id was uint8_t, silently truncating chain IDs above 255. Base (8453), Arbitrum (42161), Avalanche (43114) and others all overflow a byte, causing tokenByChainAddress to match the wrong tokens or return UnknownToken for valid ERC-20 transfers. Widen chain_id to uint32_t in TokenType struct and both lookup functions (tokenByChainAddress, tokenByTicker).
deps/device-protocol → 8ef74da (feat(ripple): memo + THORChain routing) deps/python-keepkey → bf870e6 (7.14.2: XRP memo + EVM depositWithExpiry + msg-signing)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TokenType.chain_idwasuint8_t, silently truncating chain IDs above 255. Base (8453), Arbitrum (42161), Avalanche C-Chain (43114), and others all overflow a byte —tokenByChainAddresswould either match wrong tokens or returnUnknownTokenfor valid ERC-20 transfers on these chains.Widen
chain_idtouint32_tin the struct and both lookup functions.Test plan