fix: TRON signing — stop displaying deprecated fields not in raw_data#238
Open
BitHighlander wants to merge 2 commits into
Open
fix: TRON signing — stop displaying deprecated fields not in raw_data#238BitHighlander wants to merge 2 commits into
BitHighlander wants to merge 2 commits into
Conversation
fsm_msgTronSignTx displayed to_address and amount from deprecated proto fields that are NOT included in the raw_data bytes being signed. A malicious host could show one transfer on screen while getting a different transaction signed. Replace with a single blind-sign prompt that shows only the raw_data byte count, which is the actual data committed to by the signature.
deps/device-protocol → 8ef74da (feat(ripple): memo + THORChain routing) deps/python-keepkey → bf870e6 (7.14.2: XRP memo + EVM depositWithExpiry + msg-signing)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fsm_msgTronSignTxwas displayingto_addressandamountfrom deprecated proto fields that are not included in theraw_databytes being signed. A malicious host could show one transfer on screen while getting a completely different transaction signed.Replace with a single blind-sign prompt showing only the
raw_databyte count — the actual data committed to by the signature.Test plan