ci: add manual @bitgo-beta SDK bump workflow#202
Open
pranavjain97 wants to merge 1 commit into
Open
Conversation
83cee97 to
a0bec85
Compare
gokulhost
reviewed
May 14, 2026
Comment on lines
+20
to
+24
| - name: Setup Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: '22.1.0' | ||
| cache: 'npm' |
There was a problem hiding this comment.
Suggested change
| - name: Setup Node.js | |
| uses: actions/setup-node@v4 | |
| with: | |
| node-version: '22.1.0' | |
| cache: 'npm' | |
| - name: Get Node.js version from package.json | |
| id: node-version | |
| run: echo "NODE_VERSION=$(jq -r .engines.node package.json)" >> $GITHUB_OUTPUT | |
| - name: Setup Node.js from engines | |
| uses: actions/setup-node@v4 | |
| with: | |
| node-version: ${{ steps.node-version.outputs.NODE_VERSION }} | |
| cache: 'npm' |
so we do not have to hardcode in CI
Contributor
There was a problem hiding this comment.
Very neat approach! 😮
just a question though: looks like we have engines defined as >= 22.x, so it would mean, the node version retrieved could be 22.x / 23.x/ 24.x; might be hard to reproduce, what do you guys think?
There was a problem hiding this comment.
That's a valid concern. We should be pinning node versions I guess?
| - name: Bump @bitgo-beta versions | ||
| run: npm run bump-versions | ||
|
|
||
| - name: Regenerate lockfile |
Contributor
There was a problem hiding this comment.
Minor optimization but if we add a step like the following:
- name: Early exit if nothing changed
run: |
if git diff --quiet HEAD -- package.json; then
echo "No version bumps found, exiting."
exit 0 # or use $GITHUB_OUTPUT to skip remaining steps
fi
we can early return after the Bump version step
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.