chore: bump public types#8759
Merged
Merged
Conversation
dd0cc2b to
52a0bad
Compare
52a0bad to
3c814fa
Compare
Contributor
Author
|
dev-ex overrode breaking changes lint - was a false positive. |
pranavjain97
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@bitgo/public-typesfrom5.97.0to6.9.0insdk-core,abstract-lightning,sdk-coin-sol,sdk-coin-flrp,bitgo, andexpressProblem
The
5.97.0pin caused npm to hoist a separate@bitgo/public-types@5.97.0copy intosdk/node_modules/inside thewallet-platformworkspace in bitgo-microservices. This shadowed the top-level6.5.1copy, solistWebhooks.ts(which lives inpackages/wallet-platform/sdk/) compiled and ran against anOrganizationWebhookTypethat predatesidvStatus.At runtime, when sumsub-service called
POST /api/v2/internal/webhook/listwith{ organizationId, type: "idvStatus" }, wallet-platform's io-ts validation rejected"idvStatus"as an invalidOrganizationWebhookType, returning a 400 — even thoughidvStatushad been correctly added to the enum in@bitgo/public-types@6.5.0.Why it's safe
No exports were removed between
5.97.0and6.9.0. The bump is purely additive —6.9.0is a superset of5.97.0's public API.Resolutions
Added two yarn resolutions entries to fix a hoisting regression introduced by this bump:
"/cliui/strip-ansi": "6.0.1",
"/cliui/string-width": "4.2.3",
"**/yargs/cliui/string-width": "4.2.3"
Upgrading 6 packages from @bitgo/public-types@5.97.0 to 6.5.0 changed yarn's hoisting strategy, causing strip-ansi@7.1.0 and string-width@5.1.2 (both ESM-only) to be promoted to the root node_modules/. cliui@8.0.1 and yargs require their CJS ^6/^4 counterparts — without a nested copy, require('strip-ansi') and require('string-width') returned ESM modules where mixin.stripAnsi and s.stringWidth are not functions, crashing lerna list and any yargs-based CLI. The resolutions force the CJS-compatible versions into cliui's dependency path without affecting other packages.
Test plan
@bitgo/public-types@5.97.0copy inwallet-platform/sdk/node_modules/@bitgo-betabuilds from this, the sumsub-serviceidvStatuswebhook flow succeeds end-to-end on staging🤖 Generated with Claude Code