Skip to content

chore: bump public types#8759

Merged
alia-bitgo merged 1 commit into
masterfrom
CAAS-1427-bump-public-types
May 13, 2026
Merged

chore: bump public types#8759
alia-bitgo merged 1 commit into
masterfrom
CAAS-1427-bump-public-types

Conversation

@alia-bitgo
Copy link
Copy Markdown
Contributor

@alia-bitgo alia-bitgo commented May 12, 2026

Summary

  • Bumps @bitgo/public-types from 5.97.0 to 6.9.0 in sdk-core, abstract-lightning, sdk-coin-sol, sdk-coin-flrp, bitgo, and express

Problem

The 5.97.0 pin caused npm to hoist a separate @bitgo/public-types@5.97.0 copy into sdk/node_modules/ inside the wallet-platform workspace in bitgo-microservices. This shadowed the top-level 6.5.1 copy, so listWebhooks.ts (which lives in packages/wallet-platform/sdk/) compiled and ran against an OrganizationWebhookType that predates idvStatus.

At runtime, when sumsub-service called POST /api/v2/internal/webhook/list with { organizationId, type: "idvStatus" }, wallet-platform's io-ts validation rejected "idvStatus" as an invalid OrganizationWebhookType, returning a 400 — even though idvStatus had been correctly added to the enum in @bitgo/public-types@6.5.0.

Why it's safe

No exports were removed between 5.97.0 and 6.9.0. The bump is purely additive — 6.9.0 is a superset of 5.97.0's public API.

Resolutions

Added two yarn resolutions entries to fix a hoisting regression introduced by this bump:

"/cliui/strip-ansi": "6.0.1",
"
/cliui/string-width": "4.2.3",
"**/yargs/cliui/string-width": "4.2.3"

Upgrading 6 packages from @bitgo/public-types@5.97.0 to 6.5.0 changed yarn's hoisting strategy, causing strip-ansi@7.1.0 and string-width@5.1.2 (both ESM-only) to be promoted to the root node_modules/. cliui@8.0.1 and yargs require their CJS ^6/^4 counterparts — without a nested copy, require('strip-ansi') and require('string-width') returned ESM modules where mixin.stripAnsi and s.stringWidth are not functions, crashing lerna list and any yargs-based CLI. The resolutions force the CJS-compatible versions into cliui's dependency path without affecting other packages.

Test plan

  • Lock file resolves without a nested @bitgo/public-types@5.97.0 copy in wallet-platform/sdk/node_modules/
  • Existing unit tests pass across affected modules
  • After wallet-platform picks up new @bitgo-beta builds from this, the sumsub-service idvStatus webhook flow succeeds end-to-end on staging

🤖 Generated with Claude Code

@alia-bitgo alia-bitgo requested a review from a team as a code owner May 12, 2026 21:17
@linear-code
Copy link
Copy Markdown

linear-code Bot commented May 12, 2026

CAAS-1427

@alia-bitgo alia-bitgo force-pushed the CAAS-1427-bump-public-types branch 2 times, most recently from dd0cc2b to 52a0bad Compare May 13, 2026 00:03
@alia-bitgo alia-bitgo temporarily deployed to breaking-changes-override May 13, 2026 00:13 — with GitHub Actions Inactive
@alia-bitgo alia-bitgo temporarily deployed to breaking-changes-override May 13, 2026 15:56 — with GitHub Actions Inactive
@alia-bitgo alia-bitgo force-pushed the CAAS-1427-bump-public-types branch from 52a0bad to 3c814fa Compare May 13, 2026 16:08
@alia-bitgo alia-bitgo deployed to breaking-changes-override May 13, 2026 16:18 — with GitHub Actions Active
@alia-bitgo
Copy link
Copy Markdown
Contributor Author

dev-ex overrode breaking changes lint - was a false positive.

@alia-bitgo alia-bitgo merged commit c2658d6 into master May 13, 2026
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants