Skip to content

fix: Use the new #classicwebcam_container#39

Open
MikeRatcliffe wants to merge 2 commits into
BillyBlaze:masterfrom
MikeRatcliffe:classicwebcam_container
Open

fix: Use the new #classicwebcam_container#39
MikeRatcliffe wants to merge 2 commits into
BillyBlaze:masterfrom
MikeRatcliffe:classicwebcam_container

Conversation

@MikeRatcliffe

@MikeRatcliffe MikeRatcliffe commented May 29, 2023

Copy link
Copy Markdown

Since OctoPrint/OctoPrint#4628 we need to use #classicwebcam_container otherwise all controls and text information provided by this plugin is display:none.

Fixes #38 (Landed in OctoPrint v1.9.0)

Since OctoPrint/OctoPrint#4628 we need to use `#classicwebcam_container` otherwise all controls and text information provided by this plugin is `display:none`.
@SK-StYleZ

Copy link
Copy Markdown

thank you for the fix, mike!
can someone please review & merge this pr?
thanks! <3

@dpslwk

dpslwk commented Sep 28, 2023

Copy link
Copy Markdown

@BillyBlaze can you merge?

@lordofbikes lordofbikes mentioned this pull request Feb 17, 2024
@lordofbikes

Copy link
Copy Markdown

I recently upgraded my OctoPrint instance and had this issue too.
After applying this patch to my instance text information is back and working again.

I opened #41 to see if there is any response.

If not, @MikeRatcliffe can you imagine to adopt the plugin and give it a new home?
Otherwise I can do so, to get this useful plugin back working for other users too.

@MikeRatcliffe

MikeRatcliffe commented Feb 19, 2024

Copy link
Copy Markdown
Author

I recently upgraded my OctoPrint instance and had this issue too. After applying this patch to my instance text information is back and working again.

I opened #41 to see if there is any response.

If not, @MikeRatcliffe can you imagine to adopt the plugin and give it a new home? Otherwise I can do so, to get this useful plugin back working for other users too.

@lordofbikes I would imaging that you are busy enough with LibreCAD, so I am happy to take over as maintainer for this plugin.

Note to self: if @BillyBlaze doesn't respond to #41 by 4 Mar 2024 then I will need to follow https://github.com/OctoPrint/plugins.octoprint.org/pull/651/files in order to add myself as the new maintainer.

In the meantime, I will update the code in my repo to use more modern methods.

@Drzet

Drzet commented Jul 7, 2024

Copy link
Copy Markdown

Thank you, it's working !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

All controls and text information provided by this plugin is display:none

6 participants