refactor(reports): native aircraft from live Flight — ADR-0033 root fix (v2.78.0, ADR-0038)#40
Merged
Merged
Conversation
…top copying junction aircraft_id (v2.78.0, ADR-0038) Root fix for the ADR-0033 junction-staleness class. Native flights (flight_id set) now resolve aircraft from the live Flight.aircraft join, never the junction's copied aircraft_id (which snapshots at attach time and goes stale). Native attach stops copying aircraft_id (single + bulk). Legacy-ODL keeps the junction read (Phase 2 will materialize it). Shared _build_aircraft_cards for PDF + narrative. A serial registered after attach now shows with no re-attach. 4 new tests + 2 contract updates; 511 pass. No columns dropped. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 1 flight-attach unification: native flights resolve aircraft from the live Flight join, never the stale junction aircraft_id copy; native attach stops copying it. Fixes the ADR-0033 staleness class at root (a serial registered after attach now shows with no re-attach). Legacy-ODL keeps the junction read (Phase 2 defers). No columns dropped; ADR-0007/0029 untouched. 4 new tests (incl. the late-link scenario) + 2 contract updates; 511 pass.