fix: shared shell accessibility (Navbar, SelectPicker, focus) - #3
Open
smmariquit wants to merge 2 commits into
Open
fix: shared shell accessibility (Navbar, SelectPicker, focus)#3smmariquit wants to merge 2 commits into
smmariquit wants to merge 2 commits into
Conversation
Open desktop nav menus on keyboard focus, wire Escape/aria for mobile menus, make SelectPicker a real multiselect listbox (no nested buttons), and add clear labels plus focus-visible rings on shared shell controls.
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aria-expanded/aria-controlson mobile menu + submenus, focus-visible rings, configurableconfig.lgu.logoPath, Hotlines as external<a>aria-controls/ multiselect semanticsTest plan
file:../betterlb-ui), Tab through desktop nav — dropdowns open on focus and close on Escape / blurnpm run type-check && npm run build