Refactor AbstractSelectionAction constructor and listener#1
Closed
Bertildk wants to merge 5 commits into
Closed
Conversation
Changed constructor visibility to protected and refactored property change listener for clarity. Introduced ENABLED_PROPERTY constant and made propertyHandler transient. Simplified listener logic and improved code readability.
Unit tests for CopyAction, CutAction, and DeleteAction in jhotdraw-actions. Added JUnit as a test dependency in jhotdraw-actions/pom.xml and in the root pom.xml to manage versions.
Introduced Mockito as a test dependency in both project and module POM files. Refactored CopyActionTest and CutActionTest to use mock Clipboard and TransferHandler, replacing direct clipboard assertions with mock verifications for improved reliability and isolation.
SonarQube refactoring for readabillity and unnecesarry code removed
Commit contains BDD Test for the PastAction, aswell as Pom.xml dependency additions of JGiven, AssertJ.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed constructor visibility to protected and refactored property change listener for clarity. Introduced ENABLED_PROPERTY constant and made propertyHandler transient. Simplified listener logic and improved code readability.