fix(updater): handle 4-part version strings to prevent TypeInitializationException on nightly builds#2249
Merged
Belphemur merged 3 commits intoJun 23, 2026
Conversation
Nightly releases stamp AssemblyInfo with a version like "7.1.0.229925" which has a fourth component not accepted by NuGet.Versioning's SemanticVersion.Parse, causing a TypeInitializationException. - Add ParseVersion() helper that truncates to major.minor.patch before parsing, making static AppVersion initialization safe for nightly builds - Add a Where filter in CheckForUpdate to skip releases whose tag cannot be parsed as a SemanticVersion (defensive guard) - Add VersionTest cases for 4-part nightly version truncation Closes #2248 Co-authored-by: Belphemur <197810+Belphemur@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix System.TypeInitializationException for UpdateChecker
fix(updater): handle 4-part version strings to prevent TypeInitializationException on nightly builds
Jun 23, 2026
Owner
|
@copilot Only keep the last 4 or 5 digits of the patch when present, if that is acceptable for version parsing |
Instead of discarding the 4th version component entirely (which made all nightly builds report as the same version), use the last 5 digits of the revision number as the patch component. e.g. "7.1.0.229925" → SemanticVersion 7.1.29925 This preserves ordering between nightly builds and is acceptable to NuGet.Versioning's SemanticVersion parser. Co-authored-by: Belphemur <197810+Belphemur@users.noreply.github.com>
Contributor
Author
Done. |
Belphemur
deleted the
copilot/soundswitch-41w-fix-type-initialization-exception
branch
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the updater’s version-handling logic so nightly builds stamped with a 4-part version string (e.g., 7.1.0.229925) no longer crash UpdateChecker during static initialization, restoring update-check functionality for nightlies.
Changes:
- Added
ParseVersion()helper and used it forUpdateChecker’s staticAppVersioninitialization. - Added filtering of GitHub releases to skip tags that can’t be parsed as semantic versions before ordering.
- Added/updated tests for nightly (4-part) and standard (3-part) version parsing, plus some formatting-only changes in icon extractor files.
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| SoundSwitch/Framework/Updater/UpdateChecker.cs | Introduces ParseVersion() for 4-part versions and filters invalid release tags before ordering. |
| SoundSwitch.Tests/VersionTest.cs | Adds parameterized tests for nightly/standard version parsing behavior. |
| SoundSwitch.Tests/AudioDeviceIconExtractorTests.cs | Formatting/whitespace-only normalization. |
| SoundSwitch.Common/Framework/Audio/Icon/AudioDeviceIconExtractor.cs | Formatting/whitespace-only normalization. |
Comment on lines
+131
to
+133
| foreach (var release in (releases ?? Array.Empty<Release>()) | ||
| .Where(release => SemanticVersion.TryParse(release.TagName.Substring(1), out _)) | ||
| .OrderByDescending(release => SemanticVersion.Parse(release.TagName.Substring(1)))) |
Comment on lines
+27
to
+38
| var parts = rawVersion.Split('.'); | ||
| SemanticVersion parsed; | ||
| if (parts.Length >= 4 && int.TryParse(parts[3], out var revision)) | ||
| { | ||
| var patch = revision % 100_000; | ||
| parsed = new SemanticVersion(int.Parse(parts[0]), int.Parse(parts[1]), patch); | ||
| } | ||
| else | ||
| { | ||
| var truncated = string.Join(".", parts.Take(3)); | ||
| parsed = SemanticVersion.Parse(truncated); | ||
| } |
Comment on lines
+52
to
+61
| var parts = version.Split('.'); | ||
| if (parts.Length >= 4 && int.TryParse(parts[3], out var revision)) | ||
| { | ||
| var patch = revision % 100_000; | ||
| return new SemanticVersion(int.Parse(parts[0]), int.Parse(parts[1]), patch); | ||
| } | ||
|
|
||
| var truncated = string.Join(".", parts.Take(3)); | ||
| return SemanticVersion.Parse(truncated); | ||
| } |
Comment on lines
+21
to
+24
| [TestCase("7.1.0.229925", "7.1.29925")] | ||
| [TestCase("1.2.3.456", "1.2.456")] | ||
| [TestCase("1.2.3.100001", "1.2.1")] | ||
| [TestCase("1.2.3", "1.2.3")] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nightly builds stamp
AssemblyInfowith a 4-part version like7.1.0.229925.SemanticVersion.Parse(NuGet.Versioning) rejects this format, causing the static initializer ofUpdateCheckerto throw — poisoning the entire type and breaking all update checks.Changes
UpdateChecker.cs— AddedParseVersion()helper that maps a 4-part version to a valid semver by using the last 5 digits of the revision component as the patch number (e.g.7.1.0.229925→7.1.29925). This preserves ordering between nightly builds rather than collapsing them all to the same version:Used for the static
AppVersionfield (the crash site) and applied a defensive.Where(TryParse)filter inCheckForUpdateto skip any release tags that aren't valid semver.VersionTest.cs— Added parameterized tests covering 4-part nightly versions and standard 3-part versions to guard against regression.