Allow for "sequential control" such as [cc, cccv, rest, ...]#157
Open
augustjohansson wants to merge 28 commits into
Open
Allow for "sequential control" such as [cc, cccv, rest, ...]#157augustjohansson wants to merge 28 commits into
augustjohansson wants to merge 28 commits into
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sequence cycling protocol basically this allows for using an array of controls:
cc = Dict(..)
rest = Dict(..)
cccv = Dict(..)
cycling_protocol = CyclingProtocol(
Dict(
"Protocol" => "Sequence",
"InitialStateOfCharge" => 1.0,
"Steps" => [cc, rest, cccv, cc, cccv, rest, cc, ...]
)
)
There's also work on rampup:
allowing for rampup at each of the steps in the sequence
rampup between the cc and the cv in a cccv. This will change your precise results if you use this.
the default output when using rampup is to return the states at the rampup time steps as well. This is also new.
Starting rest and sequence controllers
Test sequence protocol
Add rampup
example demonstrating sequence control
rename vars
Allow for rampup at each discontinuity and new sequence step
Work on cccv rampup
move current function
clean up and add comments
RampUp documentation
Disable rampup for the tests to pass since we now return extra timesteps
Add comments
Remove cccv. Only use CCCV
fix a few things from the merge