[codex] Include all unit tests in backend runner#7890
Conversation
Greptile SummaryThis PR registers 14 existing unit test files that were missing from
Confidence Score: 5/5Safe to merge — the change only adds pytest invocations to a CI shell script; no application logic is touched. Every one of the 14 newly referenced test files was verified to exist in backend/tests/unit/. The duplicate removal is correct, and the intentionally failing test_goal_extraction_batch.py is explicitly left out with a noted reason. No application code is modified. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[backend/test.sh] --> B[set -euo pipefail]
B --> C[Run 160 unique pytest files]
C --> D{All pass?}
D -- Yes --> E[CI passes]
D -- No --> F[Script exits early]
subgraph "14 Newly Added Tests"
G[test_audiobuffer_guard.py]
H[test_diarizer_embedding_decoder_bypass.py]
I[test_file_upload_security.py]
J[test_file_upload_endpoint_security.py]
K[test_goals_id_fallback.py]
L[test_high_priority_usage_tracking.py]
M[test_mcp_memory_filters.py]
N[test_memories_user_review.py]
O[test_memories_validation.py]
P[test_memory_category_auto.py]
Q[test_new_usage_tracking_gaps.py]
R[test_notification_token_cleanup.py]
S[test_phone_calls.py]
T[test_twilio_service.py]
end
C --> G & H & I & J & K & L & M & N & O & P & Q & R & S & T
subgraph "Excluded (currently failing)"
U[test_goal_extraction_batch.py]
end
Reviews (1): Last reviewed commit: "Include missing unit tests in backend ru..." | Re-trigger Greptile |
68c971c to
a0b0d9a
Compare
kodjima33
left a comment
There was a problem hiding this comment.
Test-only stabilization (import isolation / stubs); zero product risk, CI not failing.
a0b0d9a to
5eb1bdb
Compare
ClawSweeper local pilot reviewRecommendation: keep open; looks suitable for normal maintainer and CI review. What it found:
Related context: #7891 and #7937 cover adjacent missing-test work; neither supersedes this PR. #7937 is the focused path for test_phone_calls.py. Suggested next step: review and land this narrow runner cleanup if maintainers agree with the test selection. Posted from a local report-only ClawSweeper pilot by request; no labels, closes, repairs, or merges were performed. |
5eb1bdb to
9cddfcc
Compare
kodjima33
left a comment
There was a problem hiding this comment.
Backend test-runner chore (include all unit tests), CI green
Summary
backend/test.shso the backend CI runner exercises them.test_auth_redirect_uri.pyinvocation.backend/tests/unit/test_*.py: 0 missing, 0 duplicate entries.Why
backend/AGENTS.mdsays new unit test files should be added totest.shor they will not run in CI. A current local comparison now finds everybackend/tests/unit/test_*.pyfile listed exactly once inbackend/test.sh.Refresh
mainat1a5824403b.9cddfccf35.Validation
MISSING_COUNT=0,DUP_COUNT=0backend/test.sh's execution model: 175 passedtest_audiobuffer_guard.py-> 15 passedtest_diarizer_embedding_decoder_bypass.py-> 2 passedtest_file_upload_endpoint_security.py-> 13 passedtest_file_upload_security.py-> 13 passedtest_goals_id_fallback.py-> 9 passedtest_high_priority_usage_tracking.py-> 21 passedtest_mcp_memory_filters.py-> 8 passedtest_memories_user_review.py-> 6 passedtest_memories_validation.py-> 11 passedtest_memory_category_auto.py-> 7 passed, 1 warningtest_new_usage_tracking_gaps.py-> 45 passedtest_notification_token_cleanup.py-> 2 passedtest_phone_calls.py-> 18 passed, 1 warningtest_twilio_service.py-> 5 passedC:\Program Files\Git\bin\bash.exe -n backend/test.shgit diff --checkscripts/pre-commitwith the backend Windows venv and local Dart SDK onPATH