Add back button to host setup screen#9
Merged
Conversation
…uality label - Session codes are now 6 digits (0-9) only — no letters - Mobile side panel converted from left-slide overlay to bottom sheet with drag handle and smooth spring easing - Header cleaned up to a tight single row (no flex-wrap, logo hidden, code highlighted as gold pill) - Activity bar stays as bottom tab bar with labels; z-index and heights unified - "Resolution" renamed to "Feed Quality (controls what students see)" with plain option labels - Setup screen padding tuned for small screens https://claude.ai/code/session_01MVs3291TLJapxhwLrCei3U
There was a problem hiding this comment.
Pull request overview
This PR primarily updates the host setup experience by adding a “Back” navigation link on host.html, but it also includes additional changes affecting session-code generation, service-worker caching, and cache-control headers.
Changes:
- Add a “Back” link above the host setup card and adjust host page styling/responsive layout (
host.html). - Change host session code generation to 6 numeric digits (
host.js). - Update service worker cache version and introduce cache-control headers for selected assets (
sw.js,_headers).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| sw.js | Bumps service worker cache name/version. |
| host.js | Alters session-code generation logic used as the Socket.IO room identifier. |
| host.html | Adds back link and includes multiple styling/responsive adjustments. |
| _headers | Adds Cache-Control directives for sw.js/host.js/host.html. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -1,4 +1,4 @@ | |||
| const CACHE_NAME = 'eaglevision-v1'; | |||
| const CACHE_NAME = 'eaglevision-v3'; | |||
Comment on lines
66
to
70
| function generateCode() { | ||
| const chars = 'ABCDEFGHJKLMNPQRSTUVWXYZ23456789'; | ||
| let code = ''; | ||
| for (let i = 0; i < 6; i++) code += chars[Math.floor(Math.random() * chars.length)]; | ||
| for (let i = 0; i < 6; i++) code += Math.floor(Math.random() * 10); | ||
| return code; | ||
| } |
| <!-- ══════════════ SETUP SCREEN ══════════════ --> | ||
| <div id="setup-screen"> | ||
| <a href="index.html" style="align-self:flex-start;display:flex;align-items:center;gap:.35rem;color:var(--muted,#7c83a8);text-decoration:none;font-size:.9rem;margin-bottom:-.25rem;"> | ||
| <svg width="16" height="16" viewBox="0 0 20 20" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round"><polyline points="13 4 7 10 13 16"/></svg> |
Comment on lines
+1
to
+8
| /sw.js | ||
| Cache-Control: no-store, no-cache, must-revalidate | ||
|
|
||
| /host.js | ||
| Cache-Control: no-store, no-cache, must-revalidate | ||
|
|
||
| /host.html | ||
| Cache-Control: no-store, no-cache, must-revalidate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a "← Back" link above the setup card on host.html, linking back to index.html.
Generated by Claude Code