Fix -t sanitization stripping / from owner/repo template values#4
Open
adjn wants to merge 2 commits into
Open
Conversation
The character filter removed /, ., and _ which made -t unusable for owner/repo format inputs like 'BagToad/mini-arc-template'. The default value bypassed sanitization so this was never triggered in practice. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Fixes -t template argument sanitization so owner/repo-style values (and common repo-name characters) are not silently mangled.
Changes:
- Update
-tflag sanitization to preserve/,., and_in template repo inputs.
Show a summary per file
| File | Description |
|---|---|
gh-mini-arc |
Broadens the -t sanitization character allowlist so owner/repo template values remain intact. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 1
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
-tflag's character filter (tr -cd '[:alnum:]-') removed/,., and_, which made it unusable forowner/repoformat inputs likeBagToad/mini-arc-template.This was never triggered in practice because the default value is hardcoded and bypasses sanitization, but passing
-texplicitly would silently mangle the input.Fix: Preserve
/,., and_in the character filter.Spotted by Copilot code review on #3.