add support for mp4 + audio and screen_recorder.py rewritted to use FFMPEG

[RgeditV1]

patch for: #368

• add full support for mp4 + audio

• add new hotkey U for toggle mp4 recording

• screen recorder backend rewritted to FFMPEG

GIF

MP4

POKEMON.RED-2026.05.05-15.54.24.mp4

UNIT TEST TRACE

uv run python -m pytest -s -vv test_screen_recorder.py  

============================================= test session starts ==============================================
platform linux -- Python 3.11.15, pytest-9.0.3, pluggy-1.6.0 -- /home/rgedit/Documentos/repo/PyBoy/.venv/bin/python3
cachedir: .pytest_cache
benchmark: 5.2.3 (defaults: timer=time.perf_counter disable_gc=False min_rounds=5 min_time=0.000005 max_time=1.0 calibration_precision=10 warmup=False warmup_iterations=100000)
rootdir: /home/rgedit/Documentos/repo/PyBoy
configfile: pyproject.toml
plugins: xdist-3.8.0, benchmark-5.2.3, lazy-fixtures-1.4.0
collected 2 items                                                                                              

test_screen_recorder.py::test_screen_recorder_gif_ffmpeg_pipeline [screen-recorder-test] Starting GIF recorder flow
[screen-recorder-test] Toggle ON GIF recording
[screen-recorder-test] Toggle OFF GIF recording
[screen-recorder-test] Captured 2 ffmpeg calls for GIF
[screen-recorder-test] GIF call #1 args: ['/usr/bin/ffmpeg', '-y', '-f', 'rawvideo', '-pix_fmt', 'rgba', '-s:v', '160x144', '-r', '60', '-i', './recordings/screenrec-53vs8olz/video.rgba', '-vf', 'fps=60,palettegen=stats_mode=diff', './recordings/screenrec-53vs8olz/palette.png']
[screen-recorder-test] GIF call #2 args: ['/usr/bin/ffmpeg', '-y', '-f', 'rawvideo', '-pix_fmt', 'rgba', '-s:v', '160x144', '-r', '60', '-i', './recordings/screenrec-53vs8olz/video.rgba', '-i', './recordings/screenrec-53vs8olz/palette.png', '-lavfi', 'fps=60[x];[x][1:v]paletteuse=dither=bayer:bayer_scale=3:diff_mode=rectangle', './recordings/DEFAULT-ROM-2026.05.05-16.46.31.gif']
[screen-recorder-test] GIF recorder flow finished
PASSED
test_screen_recorder.py::test_screen_recorder_mp4_with_audio [screen-recorder-test] Starting MP4 recorder flow
[screen-recorder-test] Toggle ON MP4 recording
[screen-recorder-test] Toggle OFF MP4 recording
[screen-recorder-test] Captured 1 ffmpeg calls for MP4
[screen-recorder-test] MP4 call args: ['/usr/bin/ffmpeg', '-y', '-f', 'rawvideo', '-pix_fmt', 'rgba', '-s:v', '160x144', '-r', '60', '-i', './recordings/screenrec-breuoi5c/video.rgba', '-f', 's8', '-ar', '48000', '-ac', '2', '-i', './recordings/screenrec-breuoi5c/audio.s8', '-c:v', 'libx264', '-preset', 'veryfast', '-crf', '18', '-pix_fmt', 'yuv420p', '-c:a', 'aac', '-b:a', '128k', '-shortest', './recordings/DEFAULT-ROM-2026.05.05-16.46.31.mp4']
[screen-recorder-test] MP4 recorder flow finished
PASSED

============================================== 2 passed in 0.70s ===============================================

[Baekalfen]

Nice work. The only thing that doesn’t look right, is the gif. It seems like it’s dropping frames? It should be completely smooth 60 FPS, as we are storing every frame and playing it back with perfect timing.

[RgeditV1]

i was watching the gif frame rate and now im sure its working now, i cant notice a drop frame rate, try dont use visual studio to watch the gif

PD: for some reason in file explorer its see fine but using visual studio and github see too slow

File Explorer:

screenrecording-2026-05-09_12-08-28.mp4

Github Version and Visual Studio

[RgeditV1]

seems like its working fine for me

[Baekalfen]

Ok, it seems it’s not dropping frames, rather the framerate is far too low. Maybe there’s some metadata that should be configured? I think that was initially an issue with the current implementation, but I fixed it somehow with different parameters.

The current GIFs work fine in Safari, while the one you sent might be around 10-15 FPS?
https://github.com/Baekalfen/PyBoy/blob/master/extras/README/1.gif

[RgeditV1]

Ok, it seems it’s not dropping frames, rather the framerate is far too low. Maybe there’s some metadata that should be configured? I think that was initially an issue with the current implementation, but I fixed it somehow with different parameters.

The current GIFs work fine in Safari, while the one you sent might be around 10-15 FPS?
https://github.com/Baekalfen/PyBoy/blob/master/extras/README/1.gif

Yeah, your gif is fine right now
Pd: the workflows isnt working 😭😭😭

[RgeditV1]

hope you could helpme with the workflows

[Baekalfen]

You can ignore the workflow for now. As long as the macOS ones are working, it’s just some setup

[RgeditV1]

You can ignore the workflow for now. As long as the macOS ones are working, it’s just some setup

Take ur time for feedbacks
If you see something else, ill be here
🧐🧐

[Baekalfen]

Did you fix the frame rate issue? You can post a GIF here so I can verify, I’m not much at the computer these weeks

[RgeditV1]

Did you fix the frame rate issue? You can post a GIF here so I can verify, I’m not much at the computer these weeks

there isnt frame rate issue, its working now, but when u open it with github or vscode it seems slow.

look at this

screenrecording-2026-05-09_12-08-28.mp4

its really working fine

[Baekalfen]

But it also has to work in Visual Studio. There's a small detail you're missing. Try opening extras/README/1.gif. This works fine in VSCode too.

The GIFs in the readme here on GitHub are recorded with this code, so it has to keep working on GitHub.

[RgeditV1]

But it also has to work in Visual Studio. There's a small detail you're missing. Try opening extras/README/1.gif. This works fine in VSCode too.

The GIFs in the readme here on GitHub are recorded with this code, so it has to keep working on GitHub.

i think i got it

[RgeditV1]

[RgeditV1]

done, pillow added and its working as expected

[Baekalfen]

Sorry for the long wait. I think it looks good. I've tried running the tests, but there's something in one of your tests that is failing.

There might be something about installing ffmpeg on the test systems, but let me look at that afterwards.

[RgeditV1]

Sorry for the long wait. I think it looks good. I've tried running the tests, but there's something in one of your tests that is failing.

ill check it, and thanks