feat: add per-environment browser sidecar#11
Merged
Conversation
…pport Add browser as a supported service in alpine.yaml. When enabled, a browserless/chromium container joins the compose network and the dev container receives BROWSER_WS_ENDPOINT=ws://browser:3000. Also parse compose templates once at package init via template.Must instead of re-parsing on every call, removing unreachable error branches and improving coverage (91.8% -> 95.3% for generateComposeYAML). Closes #10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
browseras a supported service inalpine.yamlthat spins up abrowserless/chromiumsidecar containerBROWSER_WS_ENDPOINT=ws://browser:3000into the dev container when browser is enabledtemplate.Mustinstead of re-parsing per call, removing unreachable error branchesChanges
config.go: AddbrowsertovalidServicescompose.go: Add browser toserviceDefaults/serviceAlias, injectBROWSER_WS_ENDPOINTinto dev env, usetemplate.Mustfor pre-parsed templatescompose_test.go: 4 new test cases (browser service generation, endpoint injection, no endpoint without browser, all three services)config_test.go: 3 new test cases (browser in loadConfig, validate, all three services)README.md/alpine.yaml.example: Document browser serviceTest plan
make testpasses (97.3% coverage)services: [browser]inalpine.yamlproduces a compose file with the browser sidecarBROWSER_WS_ENDPOINTappears in dev container only when browser is enabledCloses #10