Skip to content

Ensure targetPositionChanged is always emitted with a list #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rocco8773 merged 1 commit into from
Jun 14, 2026
Merged

Ensure targetPositionChanged is always emitted with a list #184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions bapsf_motion/gui/configure/controllers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -577,7 +577,10 @@ def _validate_jog_value(self):

@Slot()
def _validate_target_position_value(self):
self.targetPositionChanged.emit(self.target_position)
target_position = self.target_position
if not isinstance(target_position, list):
target_position = []
self.targetPositionChanged.emit(target_position)

@Slot()
def _zero_axis(self):
Expand Down Expand Up @@ -840,10 +843,10 @@ def target_position(self) -> List[float] | None:
@Slot()
def _target_position_changed(self, position):
self.logger.info(f"DBC target position changed {self.target_position}")
tpos = self.target_position
if tpos is None:
tpos = []
self.targetPositionChanged.emit(tpos)
target_position = self.target_position
if target_position is None:
target_position = []
self.targetPositionChanged.emit(target_position)

def link_motion_group(self, mg: MotionGroup):
if not isinstance(mg, MotionGroup):
Expand Down
2 changes: 2 additions & 0 deletions bapsf_motion/gui/configure/motion_group_widget.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1386,6 +1386,8 @@ def _refresh_drive_control(self):
self.drive_control_widget.link_motion_group(self.mg)

target_position = self.drive_control_widget.target_position
if not isinstance(target_position, list):
target_position = []
self.drive_control_widget.targetPositionChanged.emit(target_position)

self._update_position_in_plot()
Expand Down
Loading