Switch to byte arrays for icons to keep Excel_UI compatible with dotnet#438
Draft
adecler wants to merge 1 commit into
Draft
Switch to byte arrays for icons to keep Excel_UI compatible with dotnet#438adecler wants to merge 1 commit into
adecler wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: Needs to be reviewed and merged with
BHoM/BHoM_UI#554
Issues addressed by this PR
Closes #437
As per the issue's description, this allows Excel_UI to compile with
dotnet buildwithout breaking it by usingbyte[]for icons instead of Bitmaps.Important: To be reviewed and merged on only after the beta release. I don't want to inject framework changes this close to the end of the milestone.
@michaelhoehn , I have added you as reviewer for visibility but I don't expect you to review this since you will be gone by then.
Test files
Just make sure you can build Excel_UI with
dotnet buildand that it is still loading correctly in Excel.Changelog
Additional comments