Conversation
… Links, Nodes, Panels and Openings
Replace all the SetUniqueName private methods defined for bars, nodes, panels and openings with a single method taking as input a BHoMObject. Taking advantage of polymorphism, we can minimize the repetition of code within the Toolkit.
Replace all the UpdateUniqueName private methods defined for bars, nodes, panels and openings with a single method taking as input a BHoMObject. Taking advantage of polymorphism, we can minimize the repetition of code within the Toolkit.
GCRA101
approved these changes
Jun 26, 2026
GCRA101
left a comment
GCRA101
left a comment
Contributor
There was a problem hiding this comment.
Changes to code approved.
Following the testing, the required updates/improvements to be implemented in the toolkit have been listed in the word document at the following link.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ETABS_Toolkit
Feature
Compliance