[정현수_Android] 6-2주차 과제 제출#6
Open
Rickettsia1234 wants to merge 2 commits into
Open
Conversation
JaeYoung290
reviewed
Jul 8, 2026
Comment on lines
+118
to
+119
| setTextViewText(notificationBinding.tvTitle.id, getString(R.string.notification_title)) | ||
| setTextViewText(notificationBinding.tvContent.id, getString(R.string.notification_content, count)) |
Collaborator
There was a problem hiding this comment.
tvTitle, tvContent 모두 R.id로 대체 가능해 보입니다.
Comment on lines
+156
to
165
| companion object { | ||
| const val CHANNEL_ID = "notification_channel" | ||
| const val NOTIFICATION_ID = 1 | ||
| const val ACTION_MORE = "ACTION_MORE" | ||
| const val ACTION_CLOSE = "ACTION_CLOSE" | ||
| const val ACTION_LAUNCH_MAIN2 = "ACTION_LAUNCH_MAIN2" | ||
| const val EXTRA_NOTIFICATION_ID = "NOTIFICATION_ID" | ||
| const val EXTRA_INTENT_COUNT = "INTENT_COUNT" | ||
| const val EXTRA_RETURN_COUNT = "RETURN_COUNT" | ||
| } |
Collaborator
There was a problem hiding this comment.
MainActivity.kt에서 선언한 상수를 MainActivity2.kt에서도 사용되는데, 이럴 경우 두 클래스 사이에 결합도가 높아집니다.
별도 constant 파일로 분리하시는 것도 좋아보입니다.
Comment on lines
+40
to
+57
| <TextView | ||
| android:id="@+id/btn_more" | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:text="@string/btn_more_text" | ||
| android:textColor="@color/blue_3F" | ||
| android:textSize="14sp" | ||
| android:textStyle="bold" | ||
| android:paddingEnd="24dp" /> | ||
|
|
||
| <TextView | ||
| android:id="@+id/btn_close" | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:text="@string/btn_close_text" | ||
| android:textColor="@color/red_FF" | ||
| android:textSize="14sp" | ||
| android:textStyle="bold" /> |
Collaborator
There was a problem hiding this comment.
textView라 btn_ 보다는 tv_ 접두어가 괜찮아 보입니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.