Fix SQL error in firing chart data due to only_full_group_by - #106
Open
sentry[bot] wants to merge 1 commit into
Open
Fix SQL error in firing chart data due to only_full_group_by#106sentry[bot] wants to merge 1 commit into
only_full_group_by#106sentry[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves a
yii\db\Exception: SQLSTATE[42000]: Syntax error or access violation: 1055error occurring inCandidateWorkHistory::getFiringChartData.The error was caused by selecting the
end_datecolumn without an aggregate function while grouping byMONTH(end_date), YEAR(end_date). This violates MySQL'sonly_full_group_bySQL mode, which is enabled by default in modern MySQL versions.The fix involves changing the
SELECTclause fromend_date, COUNT(*) as totaltoMIN(end_date) as end_date, COUNT(*) as total. By applyingMIN()toend_date, the query now complies withonly_full_group_by. The aliasas end_dateensures that existing downstream logic that processes theend_datecolumn remains unaffected.Fixes STUDENTHUB-BACKEND-3
Fixes TECH-2026