Fix Redux Error #9: Nested dispatch in authSlice - #39
Open
sentry[bot] wants to merge 1 commit into
Open
Conversation
✅ Deploy Preview for studenthub-student ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves Redux Error #9, which occurs when an action is dispatched while a reducer is already executing. The root cause was identified in
src/store/slices/authSlice.tswhere thesetCredentialsreducer synchronously calleduserLogin$.next({}).This synchronous emission triggered a chain of events via the
userLogin$observable's subscription insrc/init.ts, leading tooneSignalActionBasedOnStatus()and subsequentlysetShowOneSignalPromptbeing dispatched while thesetCredentialsreducer was still active.The fix involves wrapping
userLogin$.next({})in asetTimeout(() => ..., 0)call within thesetCredentialsreducer. This defers the observable emission to the next event loop tick, ensuring that the Redux reducer has completed its execution before any downstream dispatches are triggered, thus preventing the nested dispatch error.Fixes SH-STUDENT-APP-E