Dipowell/node readiness timing#1216
Closed
diamondpowell wants to merge 10 commits into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
node_readiness_timeas a separate metric in the open-source CRUD module to match internal repo behavior. The internal repo captures how long K8s nodes take to become Ready independently from when the ARM API completes. The open-source repo was missing this - it only had combined duration.Azure API says "done" when the control plane finishes, but nodes might not be schedulable yet. Capturing both timestamps separately enables regression analysis:
command_execution_time > node_readiness_time→ ARM layer is the bottlenecknode_readiness_time > command_execution_time→ K8s layer is the bottleneckChanges
kubernetes_client.py
return_timestamp=Falseparameter towait_for_nodes_ready()True, returns(ready_nodes, timestamp)tuple instead of justready_nodesaks_client.py
_run_concurrent_arm_and_readiness()helper usingasyncio.gather()create_node_pool(),scale_node_pool(), and_progressive_scale()to capture concurrent timingTiming metadata stored via
op.add_metadata():node_readiness_time: seconds from start until K8s nodes were Readycommand_execution_time: seconds from start until ARM operation completedImplementation notes
asyncio.to_thread()to run sync calls concurrentlyreturn_exceptions=Trueensures both tasks complete even if one fails, enabling partial diagnostics