[code sync] Merge code from sonic-net/sonic-swss:202511 to 202511_azd#260
Merged
mssonicbld merged 2 commits intoJul 22, 2026
Merged
Conversation
mssonicbld
commented
Jul 22, 2026
mssonicbld
commented
Collaborator
…ry (#4315) (#4701) * hftelorch: remove unused macro and add SAI return value checks What I did A collection of minor improvements and cleanups for the high frequency telemetry orchagent code: Add handleSaiCreateStatus() calls in createNetlinkChannel() for consistency with createTAM(). Add missing attrs.push_back() for SAI_TAM_REPORT_ATTR_REPORT_INTERVAL_UNIT. Use find() instead of operator[] in clearGroup() to avoid inserting default entries. Adjust clearGroup() cleanup order to delete counter subscriptions before telemetry type/report objects. Replace raw const char* fields in CounterNameMapUpdater::Message with owned std::string state for robustness. Initialize CounterNameMapUpdater::Message::m_oid to SAI_NULL_OBJECT_ID and keep it SET-only by contract. Use rvalue reference for updateStatsIDs() to enable true move semantics. Use u32 for SAI_TAM_COUNTER_SUBSCRIPTION_ATTR_STAT_ID to match the SAI metadata type. Clean up partially created hostif objects in createNetlinkChannel() if a later HOSTIF create step fails. Remove unused CONSTANTS_FILE macro and clean up commented-out code. Why I did it Identified during code review. Most of these are defensive robustness/maintainability fixes. The createNetlinkChannel() follow-up also improves failure-path behavior by avoiding leaked partially created HOSTIF objects when later create steps fail. (cherry picked from commit f54b71e) Signed-off-by: Ze Gan <zegan@microsoft.com>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.