[action] [PR:1859] vpp: Ignore NO_SUCH_ENTRY in ip_neigh_delete#124
Merged
Conversation
### why
when interface is shut, vpp automatically removes the dynamic nexthops over the interface. orchagent also deletes the nexthops over the interface. When vpp calls vl_api_ip_neighbor_add_del_t api to delete the neighbours, vpp returns NO_SUCH_ENTRY. saivpp should ignore the error.
### what this PR does
1. move all the log messages from handler to the corresponding API calls. This is because the handler doesn't have enough context (delete or add) to ignore the error.
2. Ignore NO_SUCH_ENTRY for delete operations.
3. Ignore ROUTE_ENTRY update if packet action is SAI_PACKET_ACTION_FORWARD but missing SAI_ROUTE_ENTRY_ATTR_NEXT_HOP_ID. This is possible in bulk_set like below. See the first entry.
```
20.07:04:19.106477|S|SAI_OBJECT_TYPE_ROUTE_ENTRY||{"dest":"0.0.0.0/0","switch_id":"oid:0x21000000000000","vr":"oid:0x3000000000002"}|SAI_ROUTE_ENTRY_ATTR_PACKET_ACTION=SAI_PACKET_ACTION_FORWARD||{"dest":"0.0.0.0/0","switch_id":"oid:0x21000000000000","vr":"oid:0x3000000000002"}|SAI_ROUTE_ENTRY_ATTR_NEXT_HOP_ID=oid:0x40000000000f4||{"dest":"::/0","switch_id":"oid:0x21000000000000","vr":"oid:0x3000000000002"}|SAI_ROUTE_ENTRY_ATTR_PACKET_ACTION=SAI_PACKET_ACTION_FORWARD||{"dest":"::/0","switch_id":"oid:0x21000000000000","vr":"oid:0x3000000000002"}|SAI_ROUTE_ENTRY_ATTR_NEXT_HOP_ID=oid:0x40000000000f5
```
Signed-off-by: Sonic Build Admin <sonicbld@microsoft.com>
Collaborator
Author
|
Original PR: sonic-net/sonic-sairedis#1859 |
Collaborator
Author
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
why
when interface is shut, vpp automatically removes the dynamic nexthops over the interface. orchagent also deletes the nexthops over the interface. When vpp calls vl_api_ip_neighbor_add_del_t api to delete the neighbours, vpp returns NO_SUCH_ENTRY. saivpp should ignore the error.
what this PR does
Signed-off-by: Sonic Build Admin sonicbld@microsoft.com