[action] [PR:1857] vpp: Change NO_LINUX_NL default to y#122
Merged
Conversation
### why sonic-vpp has been running with NO_LINUX_NL = y for a long time. This is the mode that has been tested. It relies on vpp-cfg-init script to set the env: https://github.com/sonic-net/sonic-platform-vpp/blob/4b1268df9bf31b8b3b7bca50a7365024baccd424/sonic-platform-modules-vpp/files/etc/config-setup/factory-default-hooks.d/10-01-vpp-cfg-init#L71-L73 The saivpp code has the default value equivalent to NO_LINUX_NL = n. This is not consistent with the default value we are using through above script. For other platforms that are using vpp data plane, we should make the default value to y so unless it is needed, those platforms do not need to create /etc/sonic/vpp/syncd_vpp_env for setting this flag. ### what this PR does change default value nbr_active to true, which is derived from NO_LINUX_NL=y env. If the env is not set, it is default to y. Signed-off-by: Sonic Build Admin <sonicbld@microsoft.com>
Collaborator
Author
|
Original PR: sonic-net/sonic-sairedis#1857 |
Collaborator
Author
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
why
sonic-vpp has been running with NO_LINUX_NL = y for a long time. This is the mode that has been tested. It relies on vpp-cfg-init script to set the env: https://github.com/sonic-net/sonic-platform-vpp/blob/4b1268df9bf31b8b3b7bca50a7365024baccd424/sonic-platform-modules-vpp/files/etc/config-setup/factory-default-hooks.d/10-01-vpp-cfg-init#L71-L73
The saivpp code has the default value equivalent to NO_LINUX_NL = n. This is not consistent with the default value we are using through above script.
For other platforms that are using vpp data plane, we should make the default value to y so unless it is needed, those platforms do not need to create /etc/sonic/vpp/syncd_vpp_env for setting this flag.
what this PR does
change default value nbr_active to true, which is derived from NO_LINUX_NL=y env. If the env is not set, it is default to y.
Signed-off-by: Sonic Build Admin sonicbld@microsoft.com