Skip to content

bump armcompute v7 -> v8 in skewer/v2#36

Merged
matthchr merged 1 commit into
mainfrom
xuxue/armcompute-v8
Jun 28, 2026
Merged

bump armcompute v7 -> v8 in skewer/v2#36
matthchr merged 1 commit into
mainfrom
xuxue/armcompute-v8

Conversation

@xuexu6666

Copy link
Copy Markdown
Contributor

What

Migrate the v2 module (github.com/Azure/skewer/v2) from azure-sdk-for-go/sdk/resourcemanager/compute/armcompute/v7 to armcompute/v8 (v8.1.0).

Why

Consumers (e.g. AKS RP) are moving to armcompute/v8. Because skewer.SKU is type SKU armcompute.ResourceSKU, a consumer on v8 cannot convert its armcompute.ResourceSKU to skewer's v7-pinned SKU. skewer needs a v8 release to unblock them.

Changes

  • v2/: rewrite armcompute/v7 -> armcompute/v8 imports across source, tests, example, and hack generator.
  • v2/go.mod: require armcompute/v8 v8.1.0; go mod tidy also moves azcore 1.19.1 -> 1.22.0.
  • v2/README.md: update doc example import.

Pure import-path bump — no API changes. ResourceSKU and the client types are identical between v7 and v8 (v8's only breaking change was Cloud Services (classic) removal, which skewer does not use).

Validation

  • go build ./...
  • go test ./... ✅ (all v2 tests pass)

Suggest releasing as v2.1.0 (minor; no API change).

Migrate the v2 module from azure-sdk-for-go armcompute/v7 to armcompute/v8 (v8.1.0). Pure import-path bump; ResourceSKU and client types are unchanged between v7 and v8 (v8's only breaking change was Cloud Services classic removal, unused here). go mod tidy also moves azcore 1.19.1 -> 1.22.0. Build + tests pass.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Migrate the github.com/Azure/skewer/v2 module from azure-sdk-for-go armcompute/v7 to armcompute/v8 so downstream consumers on v8 can interoperate with skewer.SKU (which aliases armcompute.ResourceSKU).

Changes:

  • Update all armcompute imports in v2 source, tests, example code, and the hack generator from /v7 to /v8.
  • Bump v2 module dependencies to armcompute/v8 v8.1.0 (and related Azure SDK transitive updates via go mod tidy).
  • Refresh documentation snippet imports and module sums for the v2 module.

Reviewed changes

Copilot reviewed 13 out of 14 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
v2/wrap.go Switch armcompute import to /v8.
v2/sku.go Switch armcompute import to /v8.
v2/sku_test.go Switch armcompute import to /v8.
v2/README.md Update example import to /v8.
v2/interface.go Switch armcompute import to /v8.
v2/hack/generate_vmsize_testdata.go Switch armcompute import to /v8 in generator.
v2/go.sum Update sums after dependency bumps/tidy.
v2/go.mod Require armcompute/v8 v8.1.0 and update Azure SDK versions.
v2/fakes_test.go Switch armcompute import to /v8.
v2/example/example.go Switch armcompute import to /v8.
v2/disk_test.go Switch armcompute import to /v8.
v2/data_test.go Switch armcompute import to /v8.
v2/clients.go Switch armcompute import to /v8.
v2/cache_test.go Switch armcompute import to /v8.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread v2/go.mod
@matthchr matthchr merged commit 79b51d4 into main Jun 28, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants